Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for add-on profile update for AKS clusters #4176

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix for add-on profile update for AKS clusters #4176

merged 1 commit into from
Oct 26, 2023

Conversation

LochanRn
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Allows upgrade/update of addon profiles on a running AKS cluster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4175

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6987809) 57.86% compared to head (d71965d) 57.96%.
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4176      +/-   ##
==========================================
+ Coverage   57.86%   57.96%   +0.09%     
==========================================
  Files         187      187              
  Lines       19216    19253      +37     
==========================================
+ Hits        11120    11160      +40     
+ Misses       7468     7463       -5     
- Partials      628      630       +2
Files Coverage Δ
api/v1beta1/azuremanagedcontrolplane_webhook.go 89.98% <100.00%> (+0.30%) ⬆️
azure/services/managedclusters/spec.go 55.55% <68.42%> (+2.60%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LochanRn LochanRn force-pushed the fix-addon-profile-upgdate branch 2 times, most recently from 361be05 to 005e575 Compare October 25, 2023 06:43
nojnhuh
nojnhuh reviewed Oct 25, 2023
View reviewed changes
api/v1beta1/azuremanagedcontrolplane_webhook.go Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
api/v1beta1/azuremanagedcontrolplane_webhook.go Outdated Show resolved Hide resolved
azure/services/managedclusters/spec_test.go Outdated Show resolved Hide resolved
@LochanRn LochanRn force-pushed the fix-addon-profile-upgdate branch from 005e575 to 23ab146 Compare October 25, 2023 20:19
@LochanRn LochanRn force-pushed the fix-addon-profile-upgdate branch from 23ab146 to d71965d Compare October 26, 2023 17:08
nojnhuh
nojnhuh reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a16716174cd6247d5b555464b790965ece033f2b

mboersma
mboersma approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 379a040 into kubernetes-sigs:main Oct 26, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@mboersma mboersma mboersma approved these changes

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

Assignees

@mboersma mboersma

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Addon Profiles are not being updated when in AKS clusters
4 participants
@LochanRn @k8s-ci-robot @mboersma @nojnhuh